Re: FYI: more locations (PR/360) + question

[Akim Demaille]

| This is possible because am_install_var now returns a list of
| [$location, $value] pairs.  (I have resisted the temptation to
| have a global %value_to_location hash and continue to return a
| list of values.  Enventually I'd like the 
| `[$location, $value]' pair to be an object, so it's better to
| not introduce globals.)

This is excellent!  Yes, keep on this way!  Your revamping of Automake
is brilliant!

| After the patch you get some context (plus a warning about the 
| redefinition of libfoo.a).
| ----------
| internal: libfoo_a_OBJECTS should not be defined
| Makefile.am:3:   while processing library `libfoo.a'

I think that `internal' is wrong: make it `automake' instead.
`internal' also sounds too much like `internal error'.


| Now I'm open to suggestions about how these diagnostics could be
| output in a way which is more readable.  Would it be better to
| add a new line between each diagnostic, as follow?

Well, let me speak as the devil :)  Make the real error a read message
when the TTY supports it :)


| /home/adl/projs/cvs/automake/HEAD2/tests/../lib/am/library.am: deprecated 
feature: target `libfoo.a' overrides `libfoo.a$(EXEEXT)'
| /home/adl/projs/cvs/automake/HEAD2/tests/../lib/am/library.am: change your 
target to read `libfoo.a$(EXEEXT)'
| Makefile.am:3:   while processing library `libfoo.a'
|
| /home/adl/projs/cvs/automake/HEAD2/tests/../lib/am/program.am: target 
`libfoo.a$(EXEEXT)' was defined here
| Makefile.am:1:   while processing program `libfoo.a'

Maybe we should extend to GCS to support shifting the secondary
locations to the right?  Something like:

/home/adl/projs/cvs/automake/HEAD2/tests/../lib/am/library.am: change your 
target to read `libfoo.a$(EXEEXT)'
     Makefile.am:3:   while processing library `libfoo.a'