automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: stupid-chomp-bug.patch


From: Alexandre Duret-Lutz
Subject: FYI: stupid-chomp-bug.patch
Date: 04 Dec 2001 22:28:12 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7

Shame on me: chomp() modifies its argument and return the number
of removed characters (i.e. an integer, not a string).

Index: ChangeLog
--- ChangeLog
+++ ChangeLog
@@ -1,1 +1,6 @@
+2001-12-04  Alexandre Duret-Lutz  <address@hidden>
+
+       * automake.in (macro_define): Fix misuse of chomp introduced on
+       2001-11-28.
+

Index: automake.in
===================================================================
RCS file: /home/adl/CVSROOT/automake-20011201-2207/automake.in,v
retrieving revision 1.2
diff -u -r1.2 automake.in
--- automake.in 1 Dec 2001 21:52:14 -0000       1.2
+++ automake.in 4 Dec 2001 21:10:43 -0000
@@ -5740,10 +5740,10 @@
   # Differentiate the first assignment (including with `+=').
   if ($type eq '+' && defined $var_value{$var}{$cond})
     {
-      if ($var_value{$var}{$cond} =~ /\n$/o)
+      if (chomp $var_value{$var}{$cond})
        {
          # Insert a backslash before a trailing newline.
-         $var_value{$var}{$cond} = chomp ($var_value{$var}{$cond}) . "\\\n";
+         $var_value{$var}{$cond} .= "\\\n";
        }
       elsif ($var_value{$var}{$cond})
        {

-- 
Alexandre Duret-Lutz



reply via email to

[Prev in Thread] Current Thread [Next in Thread]