[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rb8: Tidy up logic in handle_dist

From: Raja R Harinath
Subject: Re: rb8: Tidy up logic in handle_dist
Date: Thu, 16 Aug 2001 18:32:35 -0500
User-agent: Gnus/5.090004 (Oort Gnus v0.04) Emacs/21.0.104

Richard Boulton <address@hidden> writes:

> This patch simply tidies up some very confusing logic.
> I'm not sure whether patches such as this are useful, or should only be
> submitted as part of a patch to fix some problem.  I found that I couldn't
> understand properly what was going on here though, and needed to refactor
> the code so I could follow it...
> I'd appreciate some guidance on whether I should submit patches similar to
> this in future.

Actually, I think it's cleaner to not have $dist_subdir_name.  Since
$(DIST_SUBDIRS) is always defined, we should just use that directly in

So, remove 

    transform{'DIST_SUBDIR_NAME'} = $dist_subdir_name;

Maybe, add the following to $command in make_paragraphs()

    'DIST_SUBDIRS' => &variable_defined('DIST_SUBDIRS')

and change lib/am/ to read:

  if %?SUBDIRS%
          for subdir in $(DIST_SUBDIRS); do \
  endif %?SUBDIRS%


          for subdir in $(DIST_SUBDIRS); do \
  endif %?DIST_SUBDIRS%

- Hari
Raja R Harinath ------------------------------ address@hidden
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash

reply via email to

[Prev in Thread] Current Thread [Next in Thread]