[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rb1: conditionally defined rules
From: |
Tom Tromey |
Subject: |
Re: rb1: conditionally defined rules |
Date: |
05 Aug 2001 18:46:09 -0600 |
>>>>> "Richard" == Richard Boulton <address@hidden> writes:
Richard> Following Tom's suggestion, I'm numbering my patches now,
Richard> starting at rb1.
Thanks.
Richard> I submitted this one a few days ago to the wrong mailing
Richard> list: it fixes and tests a problem reported by Robert Boehne.
This seems good. I have a few nits; if you fix them then just go
ahead and check it in.
Richard> +# Reverse a list of conditionals
Richard> +sub reverse_conditions
When I read this I didn't understand `reverse_conditions'.
How about `invert_conditions'?
Also, use an Akim-style function header.
# $BOOL
# rule_define ($TARGET, $IS_AM, $COND, $WHERE)
# --------------------------------------------
... and please add an example below the dashes so that it is really
obvious what is meant to happen.
Richard> + for $undefined_cond (@undefined_conds) {
The `{' here should be on its own line.
Richard> + if rule_define ($targets, $is_am, "$cond
$undefined_cond", $file);
This line should probably be split at one of the `,'s.
Thanks,
Tom