[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [mini-patch] Fix a set of warnings

From: Tom Tromey
Subject: Re: [mini-patch] Fix a set of warnings
Date: 19 Jun 2001 19:10:14 -0600

>>>>> "Tim" == Tim Van Holder <address@hidden> writes:

Tim> This small patch allows automake to run for the CVS tree
Tim> of gas without producing these warnings:
Tim> Use of uninitialized value in substitution (s///) at automake line 1587.
Tim> Use of uninitialized value in concatenation (.) at automake line 188.
Tim> Use of uninitialized value in quotemeta at automake line 6972.

>> Can you tell me a simple way to reproduce this?

Thanks for sending the info.
I checked in a new regression test for this.

I think your patch is not the right one.  It obscures an underlying
problem, which is that we aren't generating a rule to compile the
subdir .y file.

Tim> # If m68k-parse.y is in a different directory, then ylwrap will use an
Tim> # absolute path when it invokes yacc, which will cause yacc to put the
Tim> # absolute path into the generated file.  That's a pain when it comes
Tim> # to generating snapshots, because it introduces spurious diffs.
Tim> # Since when we make the snapshots $(srcdir) = ".", we check for that
Tim> # case and handle it differently.  This means that anybody who
Tim> # configures with $(srcdir) = "." will have to set their path in the
Tim> # debugger if they want to debug m68k-parse.y.  This is bad, but on
Tim> # the other hand it's good that people who use the prebuilt
Tim> # m68k-parse.c don't get a spurious absolute path.

I think this is better in the new ylwrap.  You might consider testing
this.  If it is satisfactory you could remove this workaround...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]