[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug report] autoheader still creates .in file if no AC_CONFIG_HEADE

From: Kelley Cook
Subject: Re: [bug report] autoheader still creates .in file if no AC_CONFIG_HEADERS
Date: Sun, 12 Dec 2004 21:32:31 -0500
User-agent: Mozilla Thunderbird 1.0 (Macintosh/20041206)

Kelley Cook wrote:
If you run autoheader 2.59b on a without a AC_CONFIG_HEADERS, it will properly inform you

error: AC_CONFIG_HEADERS not found in

Nevertheless the perl script continues which appends .in to nothing thereby creating the hidden file ".in" and procedes all outputs all the defines into it.

Two easy solutions would be to either abort after the error or to set a default for $config.h |= "config.h" right after the error message.

There are likely other solutions to this bug.

I didn't mention the spare ".in" files will show up whenever you use autoreconf on a directory not using autoheader.

Anyway here is the patch for the first proposed solution.

2004-12-12  Kelley Cook  <address@hidden>

        * bin/ Exit if no AC_CONFIG_HEADERS was found.

RCS file: /cvsroot/autoconf/autoconf/bin/,v
retrieving revision 1.140
diff -p -u -d -r1.140
---       20 Aug 2004 06:17:21 -0000      1.140
+++       13 Dec 2004 02:14:41 -0000
@@ -182,8 +182,11 @@ local (%verbatim, %symbol);
 debug "$me: \`do'ing $tmp/\n" . `sed 's/^/| /' $tmp/`;
 do "$tmp/";
 warn "couldn't parse $tmp/ $@" if $@;
-error "error: AC_CONFIG_HEADERS not found in $ARGV[0]"
-  unless $config_h;
+unless ($config_h)
+  {
+    error "error: AC_CONFIG_HEADERS not found in $ARGV[0]";
+    exit 1;
+  }
 # We template only the first CONFIG_HEADER.
 $config_h =~ s/ .*//;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]