Re: Bug in XFile.pm?

[Gary V. Vaughan]

Alexandre Duret-Lutz wrote:
> Hi Gary,

Salut Alexandre!

>>>>"Gary" == Gary V Vaughan <address@hidden> writes:
> 
> 
>  Gary> While trying to autoconfiscate zlib-1.2.2 on a Linux
>  Gary> RHEL3 box, I keep seeing the following error from
>  Gary> aclocal, automake and autoconf during bootstrap:
> 
>  Gary> Use of uninitialized value in concatenation (.) or string at
>  Gary> /opt/TWWfsw/autoconf25/share/Autom4te/XFile.pm line 229.
> 
>  Gary> XFile.pm hasn't changed in CVS autoconf vs the erroring file.
> 
> Could you try this?
> 
> --- XFile.pm  23 Oct 2003 14:29:22 -0000      1.8
> +++ XFile.pm  1 Nov 2004 15:56:59 -0000
> @@ -228,7 +228,8 @@
>    # Admittedly this is a bit of a hack.
>    if (!flock ($fh, $mode)
>        && (!$!{ENOLCK}
> -       || " -$ENV{'MAKEFLAGS'}" =~ / (-[BdeikrRsSw]*j|---?jobs)/))
> +       || (exists $ENV{'MAKEFLAGS'}
> +           && " -$ENV{'MAKEFLAGS'}" =~ / (-[BdeikrRsSw]*j|---?jobs)/)))
>      {
>        my $file = $fh->name;
>        fatal "cannot lock $file with mode $mode (perhaps you are running make 
> -j on a lame NFS client?): $!";
> 
> [...]

Yep.  That does the trick.  Thanks!

> Running automake before aclocal is a mistake.

Gah!  I knew that ;-)

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature