[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: tabs in configure.in?
|
From: |
Akim Demaille |
|
Subject: |
Re: tabs in configure.in? |
|
Date: |
26 Apr 2001 18:05:03 +0200 |
|
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley) |
| The current version of GNU gettext's m4/gettext.4 contains the following
|
| | [case " "$CONFIG_FILES" " in *" po/Makefile.in "* | *" po/Makefile.in:"*)
| | sed -e "/POTFILES =/r po/POTFILES" po/Makefile.in > po/Makefile
| | ;;
| | esac])
|
|
| compared to
|
| [case "$CONFIG_FILES" in *po/Makefile.in*)
| ...
|
| in older versions. Why they put in all these additional spaces in the first
| place is not obvious to me at all, but that's how it is now.
Indentation, nothing else.
| Anyway, that case statement is never entered because the troublesome
| configure.in uses tabs:
|
| | AC_OUTPUT(Makefile intl/Makefile m4/Makefile
| | <TAB>po/Makefile.in doc/Makefile contrib/Makefile
Indeed, but it is gettext.m4 code I would criticize. (well, first of
all Autoconf 2.13 is guilty for not providing the needed features, but
there is now AC_CONFIG_FILES which should address their needs).
Rather, they should loop. They wanted to optimize, but made the code
more fragile.
| As I said, I'd advocate not to use any tabs at all.
Killing tabs would be very bad. Say, you test some Make feature.
There are some \t in Autoconf's configure we want to keep.
Do you mean we should @\t@ ?