autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: grep had to switch: AC_PROG_CC_STDC -> AC_PROG_CC


From: Paul Eggert
Subject: Re: FYI: grep had to switch: AC_PROG_CC_STDC -> AC_PROG_CC
Date: Wed, 24 Oct 2012 12:29:13 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

On 10/24/2012 02:01 AM, Jim Meyering wrote:
> When attempting to bootstrap grep.git using
> autoconf.git (v2.69-37-gb9dc6b6), I see this failure:
> 
>     autoreconf: running: aclocal -I m4 -I m4
>     configure.ac:81: error: AC_PROG_CC cannot be called after AM_PROG_CC_C_O

Yeowch.  Thanks for reporting this.  The problem arises because
Automake's AM_PROG_CC_C_O redefines AC_PROG_CC.

We don't want to discourage people from using AC_PROG_CC,
so this is an Autoconf bug.  I installed this into Autoconf:


>From 0cc5d3c97d4446dfb198e20f13b9850ee237ab3b Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Wed, 24 Oct 2012 12:25:34 -0700
Subject: [PATCH] AC_PROG_CC_C89, AC_PROG_CC_C99, AC_PROG_CC_STDC: Use
 AU_DEFUN

This fixes a bug introduced by the most recent change to c.m4.
Problem reported by Jim Meyering in
<http://lists.gnu.org/archive/html/autoconf/2012-10/msg00048.html>.
* lib/autoconf/c.m4 (AC_PROG_CC_C89, AC_PROG_CC_C99, AC_PROG_CC_STDC):
Use AU_DEFUN and AC_REQUIRE, not AU_ALIAS, as the latter is not
compatible with how Automake redefines AC_PROG_CC.
---
 lib/autoconf/c.m4 | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/lib/autoconf/c.m4 b/lib/autoconf/c.m4
index 4a84489..0802f85 100644
--- a/lib/autoconf/c.m4
+++ b/lib/autoconf/c.m4
@@ -1448,15 +1448,27 @@ dnl preferably extc11.
 
 # AC_PROG_CC_C89
 # --------------
-AU_ALIAS([AC_PROG_CC_C89], [AC_PROG_CC])
+# Do not use AU_ALIAS here and in AC_PROG_CC_C99 and AC_PROG_CC_STDC,
+# as that'd be incompatible with how Automake redefines AC_PROG_CC.  See
+# <http://lists.gnu.org/archive/html/autoconf/2012-10/msg00048.html>.
+AU_DEFUN([AC_PROG_CC_C89],
+  [AC_REQUIRE([AC_PROG_CC])],
+  [$0 is obsolete; use AC_PROG_CC]
+)
 
 # AC_PROG_CC_C99
 # --------------
-AU_ALIAS([AC_PROG_CC_C99], [AC_PROG_CC])
+AU_DEFUN([AC_PROG_CC_C99],
+  [AC_REQUIRE([AC_PROG_CC])],
+  [$0 is obsolete; use AC_PROG_CC]
+)
 
 # AC_PROG_CC_STDC
 # ---------------
-AU_ALIAS([AC_PROG_CC_STDC], [AC_PROG_CC])
+AU_DEFUN([AC_PROG_CC_STDC],
+  [AC_REQUIRE([AC_PROG_CC])],
+  [$0 is obsolete; use AC_PROG_CC]
+)
 
 
 # AC_C_BACKSLASH_A
-- 
1.7.11.7





reply via email to

[Prev in Thread] Current Thread [Next in Thread]