Re: autoconf-2.66: AC_CONFIG_SUBDIRS warns

[Eric Blake]

----- "Ralf Wildenhues" <address@hidden> wrote:

> Hellom
> 
> * Eric Blake wrote on Sat, Jul 03, 2010 at 09:59:35PM CEST:
> > ----- "Bruno Haible" wrote:
> > > In the newest autoconf 2.66, AC_CONFIG_SUBDIRS warns when it is
> > > invoked with more than one directory. But this way of invoking it
> is
> > > supported, see the doc:
> > 
> > Thanks for the report, and sorry for the regression.  Does this
> > (untested) patch fix things for you?
> 
> Proposed patch for this.  OK to commit?

Yes, looks good.

> 
> Please note that I'm trying to merely fix the regression part here. 
> The
> Subdirectories node of the manual also documents:
> 
>      If a given DIR is not found, an error is reported: if the
>      subdirectory is optional, write:
> 
>           if test -d "$srcdir/foo"; then
>             AC_CONFIG_SUBDIRS([foo])
>           fi
> 
> which isn't true either: we don't warn or error if a subdirectory is
> not
> present.  This is *not* a recent regression, and it's on purpose that
> I
> don't want to change this behavior before the next release; I fear
> that
> packages rely on the broken behavior but do not intend to test this
> right now.

Agreed; this would probably be better as a documentation change
rather than a code behavior change, but a separate patch for
that issue is fine.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org