[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix failure of test 38 when a shell uses $TMPDIR for here-do
Re: [PATCH] Fix failure of test 38 when a shell uses $TMPDIR for here-documents.
Wed, 20 Jan 2010 05:46:28 -0700
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:126.96.36.199) Gecko/20090812 Thunderbird/188.8.131.52 Mnenhy/0.7.6.666
According to Dmitry V. Levin on 1/19/2010 9:03 AM:
> * tests/tools.at (autotools and whitespace in file names): Create
> $TMPDIR before potential use like in other whitespace tests.
> + Fix failure of test 38 when a shell uses $TMPDIR for here-documents.
> + # skip if we cannot create such a file or directory
> + AT_CHECK([mkdir "$dir" "$TMPDIR" && touch "$file.in" || exit 77])
Why not mkdir -p, or even better, AS_MKDIR_P? That is, if $TMPDIR already
exists, you've failed this test.
> - # skip if we cannot create such a file or directory
> - AT_CHECK([mkdir "$dir" "$TMPDIR" && test -f "$file.in" || exit 77])
Oh, I see. It was code motion, of something that already assumes that
"$dir" and "$TMPDIR" must not exist prior to that point.
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
Description: OpenPGP digital signature