[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: config.status --config

From: Ralf Wildenhues
Subject: Re: config.status --config
Date: Thu, 10 Sep 2009 19:32:20 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

* Eric Blake wrote on Thu, Sep 10, 2009 at 02:01:31PM CEST:
> According to Paolo Bonzini on 9/10/2009 1:12 AM:
> > 
> >> address@hidden --config
> >> +Print the configuration settings
> > 
> > Print the arguments that were passed to @command{configure}.

I've had a similar line in an early version of the patch.  However, it's
not *quite* correct, technically.  We drop a few options when setting up
$ac_configure_args (--no-create, --no-recursion, --silent, some duplicate
arguments), and we add precious variables that came in from the
environment.  A configure script invoked by a higher-level one through
recursion may be passed --srcdir and mangled --cache-file arguments.
Also, we don't guard against the author mangling

So, the above formulation seemed more cautious to me.  But hey, if you
think being explicit here is better, that's ok with me, too.

> > Otherwise looks great, thanks!
> Agreed.  And long overdue - commit when ready.

Thanks for the reviews!  Will apply after feedback to above.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]