[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix illegal tab character in Fortran language test.

From: Eric Blake
Subject: Re: Fix illegal tab character in Fortran language test.
Date: Fri, 04 Sep 2009 05:40:22 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20090812 Thunderbird/ Mnenhy/

Hash: SHA1

[adding the list, which would have been the more appropriate place to send

According to Thomas Jahns on 9/4/2009 3:50 AM:
> Hi,
> in commit 58a97ecfca0650c90b5dffacd3565c2647f37f0d of the autoconf repository,
> you replaced several occurrences of blanks with tabs.
> Unfortunately TAB is not a legal character in Fortran source and one of the
> lines affected by your change is part of a Fortran print statement which
> therefore does no longer compile with e.g. gfortran -Werror. Thus I wanted to
> ask you to apply the attached patch.

Thanks for the report (it's especially nice when a bug report comes with a
patch, as well as a commit id where the regression was introduced).  Shows
how little I know about Fortran (and I guess things like this show why
AC_FC_FREEFORM is so important in the first place, since modern Fortran
has followed the lead of C in its change to allow freeform whitespace).  I
tweaked your patch to add a comment and quadrigraph to prevent my editor
from regressing again, added THANKS, NEWS, and ChangeLog edits, and
applied it.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -

>From 87c5dbd357ea16629300d46c93dc4b8239a01ccf Mon Sep 17 00:00:00 2001
From: Thomas Jahns <>
Date: Fri, 4 Sep 2009 11:48:44 +0200
Subject: [PATCH] Fix illegal tab character in Fortran source.

 lib/autoconf/fortran.m4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/autoconf/fortran.m4 b/lib/autoconf/fortran.m4
index 93b5f9d..99e4b6b 100644
--- a/lib/autoconf/fortran.m4
+++ b/lib/autoconf/fortran.m4
@@ -1204,7 +1204,7 @@ do
   program freeform
        ! FIXME: how to best confuse non-freeform compilers?
        print *, 'Hello ', &
-          'world.'
+          'world.'
                    [ac_cv_fc_freeform=$ac_flag; break])

reply via email to

[Prev in Thread] Current Thread [Next in Thread]