testsuite failure on Solaris

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I noticed this failure on Solaris with recent patches:

178. torture.at:161:  FAILED (torture.at:268)
./testsuite: line 1766:
/export/home/ericb/autoconf/tests/testsuite.dir/178/run: Permission denied

Running with verbose tracing, I found the culprit:

mkdir: Failed to make directory "conf10012-28611"; Permission denied
config.status: error: cannot create a temporary directory in .
stdout:
./torture.at:268: exit code was 2, expected 1

So our improved AS_ERROR logic kicked in, and preserved the fact that on
Solaris, mkdir(1) fails with status 2, not 1.  At which point, we no
longer restore write privileges to testsuite.dir/178/, and fail to create
the run script, explaining the second failure message that actually leaked
out to the terminal.  The first bug is fixed as follows.

Should we also patch autotest's at_fn_create_debugging_script to add 'test
- -w "$at_group_dir" || chmod +w "$at_group_dir"', prior to attempting to
create $at_group_dir/run, so that the first bug is not hard to re-test?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkoLZcACgkQ84KuGfSFAYBd/QCfWYQiYcnvo+XJPlwn41O5FJtC
bgsAnRX520EtkTN0f6KQW94d/dqsl55U
=/aL5
-----END PGP SIGNATURE-----

>From 043d1102b608cd8fe6b24099c7beae524060c84c Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Sat, 22 Nov 2008 08:40:39 -0700
Subject: [PATCH] Fix testsuite failure on Solaris.

* tests/torture.at (AT_CHECK_CONFIG_CREATION_NOWRITE): Normalize
failure status to 1.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog        |    6 ++++++
 tests/torture.at |    3 ++-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d72ad1f..a52182a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-11-22  Eric Blake  <address@hidden>
+
+       Fix testsuite failure on Solaris.
+       * tests/torture.at (AT_CHECK_CONFIG_CREATION_NOWRITE): Normalize
+       failure status to 1.
+
 2008-11-21  Eric Blake  <address@hidden>
 
        Clean up AS_MESSAGE_LOG_FD usage.
diff --git a/tests/torture.at b/tests/torture.at
index 1a9ea4f..4779e21 100644
--- a/tests/torture.at
+++ b/tests/torture.at
@@ -244,7 +244,8 @@ AT_CHECK_CONFIGURE([what_to_test=var-$1 --no-create])
 touch t
 chmod a-w .
 mv t t1 >/dev/null 2>&1 \
-  || AT_CHECK([./config.status var-$1 </dev/null], [1], [ignore], [ignore])
+  || AT_CHECK([./config.status var-$1 </dev/null || exit 1],
+   [1], [ignore], [ignore])
 chmod u+w .
 rm -rf t t1
 ])# AT_CHECK_CONFIG_CREATION_NOWRITE
-- 
1.6.0.4