autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: #pragma with Sun cc


From: Eric Blake
Subject: Re: #pragma with Sun cc
Date: Wed, 29 Oct 2008 06:05:46 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 10/29/2008 4:47 AM:
>> I'm wondering how best to document this portability issue in the autoconf
>> manual, and whether the AC_OPENMP macro should be taught to recognize this 
>> bug.
> 
> I don't think it's worth to disable the AC_OPENMP support in this case.
> I mean, once the program is compiled, it runs flawlessly. (But I don't know
> why it used only 4 threads although I set OMP_NUM_THREADS to 16, on a
> uniprocessor machine.)
> 
> But I agree that it should be documented. Probably it's more useful to mention
> this in the AC_OPENMP documentation, than under "Portable C and C++ 
> Programming".
> Here's a proposed wording:
>
> 2008-10-29  Bruno Haible  <address@hidden>
>
>       * doc/autoconf.texi (AC_OPENMP): Document portability pitfall.

Agreed with your reasoning, and I pushed the patch, after some editing
(since you didn't use git format-patch, git am didn't handle it very well).

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkIUZkACgkQ84KuGfSFAYAwyACgvBHIAwJDB/tBaeOLBucOYjP4
3RUAni117OXDNLR9uNLNJN8VTpUCkw7c
=rKuS
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]