autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] trim down the size of the better-shell test


From: Paolo Bonzini
Subject: Re: [PATCH] trim down the size of the better-shell test
Date: Wed, 15 Oct 2008 06:56:13 +0200
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)

>>  m4_define([_AS_RUN],
>> -[m4_ifval([$2],
>> -[{ $2 <<\_ASEOF
>> -_AS_BOURNE_COMPATIBLE
>> -$1
>> -_ASEOF
>> -}],
>> -[(eval "AS_ESCAPE(m4_expand([$1]))")])])
>> +[m4_ifval([$2], [(echo "$as_bourne_compatible"$1 | $2)],
>> +            [(eval $1)]) 2>/dev/null])
> 
> Is this guaranteed to be a portable use of echo?  The moment 
> $as_bourne_compatible, $as_required, or $as_suggested contains a \, this 
> could 
> blow up on us.  It looks like $as_echo (used by AS_ECHO) is defined by this 
> point, thanks to AS_SHELL_SANITIZE; will it always do the right thing?

echo won't, $as_echo will.

Paolo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]