autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: interrupt causes parse error in configure script


From: Eric Blake
Subject: Re: interrupt causes parse error in configure script
Date: Mon, 18 Aug 2008 06:13:48 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080708 Thunderbird/2.0.0.16 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 8/18/2008 3:23 AM:
> Here's one way to fix it.
> Since there were so many occurrences, I chose to encapsulate
> the test (and not expose/document the new macro).
> 
> Subject: [PATCH] AC_VAR_YES: new function, to handle an unusual failure
                   ^^

Typo in the commit summary.

> * lib/m4sugar/m4sh.m4 (AS_VAR_YES): New function.
> * lib/autoconf/functions.m4 (AC_CHECK_FUNC): Use it in place of
> "test AS_VAR_GET([...]) = yes"

Ah, so the problem is that ^C during the AS_VAR_GET subshell means that
test is invoked with 2 instead of the normal 3 arguments.  Quotes around
AS_VAR_GET would solve the problem, except that AS_VAR_GET contains `""`,
and we already document that "`""`" is not portable; hence your solution
of a helper variable.  Yes, this looks like it might help the matter, but
is it worth generalizing the API even further?

# AS_VAR_YES(VARIABLE, [VALUE = yes])
# -----------------------------------
# Succeed if the contents of VARIABLE match VALUE.

> 
> +# AS_VAR_YES(VARIABLE)
> +# --------------------
> +# test whether VARIABLE has value "yes".
> +m4_define([AS_VAR_YES],
> +[as_yes=AS_VAR_GET([$1]); test "x$as_yes" = xyes])

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkipZ3wACgkQ84KuGfSFAYBB5wCdGQG4F+4y/z63Eq59RfNJwBSW
LUEAoLTERy2oB7rG4FvkLejI3AQNOZiW
=96rX
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]