[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: more lenient precious variable checks

From: Eric Blake
Subject: Re: more lenient precious variable checks
Date: Tue, 25 Mar 2008 19:05:34 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20080213 Thunderbird/ Mnenhy/

Hash: SHA1

According to Ralf Wildenhues on 3/25/2008 3:48 PM:
| Back then I said that this was unacceptable, for example for
|   CPPFLAGS='-Dstring=" some  string with significant whitespace"'
| and other, possibly user-defined precious variables for which leading
| and trailing whitespace may be significant.
| My thinking is not quite so clear-cut any more, although I still feel
| that GCC build is being a bit lax.  However, maybe we can degrade the
| error into a warning if all we see are differences in whitespace runs?

The user is less likely to intentionally use strings with significant
whitespace, but a warning will alert them to that.  And as I've been
bitten by the same bug (not only gcc, but building cygwin from source), I
am very inclined to approve this.  (I only worry that the cygwin/gcc
source tree will stay stuck on 2.59 for quite some time to come).

| 2008-03-25  Ralf Wildenhues  <address@hidden>
|       Warn, not fail on whitespace-only precious variable differences.

Please apply.

| +     ac_old_val_w=`echo x $ac_old_val`

Slick way to use the shell to collapse spaces!

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.8 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]