[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 1-gary-leopard-dSYM-removal.patch

From: Ralf Wildenhues
Subject: Re: 1-gary-leopard-dSYM-removal.patch
Date: Thu, 20 Mar 2008 21:21:34 +0100
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

Hello, and sorry for the delay,

picking up this thread:

* Gary V. Vaughan wrote on Fri, Jan 18, 2008 at 10:12:09AM CET:
> I thought it better to remove all of the file droppings we check for in
>  _AC_COMPILER_OBJEXT_REJECT, incase I move to an OS that drops one of  
> the other files and try to run make distcheck for libtool...

Well, but there is no need for a loop here with several rm commands.

> Note that it is actually an a.out.dSYM file that distcheck chokes on, so
> removing conftest.dSYM is no help :-(

Thanks for this information.

> "Gary V. Vaughan" writes:
> >> another way I thought of doing it was to find the sites that call:
> >>
> >>  m4_expand_once([_AC_COMPILER_EXEEXT])
> >>  m4_expand_once([_AC_COMPILER_OBJEXT])
> >>
> >> And replace with a single:
> >>
> >>  m4_expand_once([_AC_COMPILER_CHECKS])

That would hurt GCC (and AC_NO_EXECUTABLES, which is Autoconf's copy of
GCC_NO_EXECUTABLES).  It needs those two things to be separate.

Here's a simple patch I've come up with, it passes the Autoconf
testsuite on several systems including Leopard (thanks Peter!),
I will apply it soon unless I hear complaints.


2008-03-20  Ralf Wildenhues  <address@hidden>

        * lib/autoconf/lang.m4 (_AC_COMPILER_EXEEXT): Remove a.out.dSYM
        directory created on darwin.
        (AC_NO_EXECUTABLES): Likewise; also remove objects which may be
        left over from a broken link.
        * tests/ (AC_NO_EXECUTABLES (working linker))
        (AC_NO_EXECUTABLES (broken linker)): New tests.
        Report by Gary V. Vaughan.

diff --git a/lib/autoconf/lang.m4 b/lib/autoconf/lang.m4
index f17aa8c..c67a34c 100644
--- a/lib/autoconf/lang.m4
+++ b/lib/autoconf/lang.m4
@@ -356,6 +356,7 @@ if _AC_DO_VAR(ac_link); then
+  rm -f -r a.out a.exe b.out conftest.$ac_ext conftest.o conftest.obj 
   # Setting cross_compile will disable run tests; it will
   # also disable AC_CHECK_FILE but that's generally
@@ -592,10 +593,10 @@ AC_MSG_RESULT([$ac_cv_exeext])
-ac_clean_files="$ac_clean_files a.out a.exe b.out"
+ac_clean_files="$ac_clean_files a.out a.out.dSYM a.exe b.out"
-rm -f a.out a.exe conftest$ac_cv_exeext b.out
+rm -f -r a.out a.out.dSYM a.exe conftest$ac_cv_exeext b.out
diff --git a/tests/ b/tests/
index e05a67c..c9714c2 100644
--- a/tests/
+++ b/tests/
@@ -209,3 +209,24 @@ AT_CHECK_DEFINES(
+## ------------------------------------ ##
+## AC_NO_EXECUTABLES (working linker).  ##
+## ------------------------------------ ##
+## ----------------------------------- ##
+## AC_NO_EXECUTABLES (broken linker).  ##
+## ----------------------------------- ##

reply via email to

[Prev in Thread] Current Thread [Next in Thread]