[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Be nice with file systems that don't handle unusual characte
Re: [PATCH] Be nice with file systems that don't handle unusual characters.
Tue, 4 Mar 2008 23:18:25 +0100
* Eric Blake wrote on Tue, Mar 04, 2008 at 11:06:55PM CET:
> Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes:
> > + Be nice with file systems that don't handle unusual characters.
> > +unsupported_fs_chars=
> > +for c in '\\' '"' '<' '>' '*' '?' '|'
> > +do
> > + touch "t$c" 2>/dev/null
> > + test -f "t$c" && rm -f "t$c" && continue
> > + # $c cannot be used in a file name.
> It turns out that this patch exposed a cygwin bug - open("t\\", O_RDONLY |
> O_CREAT) was creating the regular file 't' rather than failing with ENOENT
> since the directory 't\' does not exist (remembering that \ is an alternate
> directory separator, rather than a regular file name character). So I'm
> checking in this, while waiting for the cygwin maintainers to fix the bug:
Thanks for cleaning up after me. FWIW, I'm a bit surprised because this
test did not error out for me on Cygwin.
> From: Eric Blake <address@hidden>
> Date: Tue, 4 Mar 2008 14:28:54 -0700
> Subject: [PATCH] Ignore tests that require read-only directories under root.
I noted that the actual patch you checked in,
was good, but your post showed the other one.
> * tests/torture.at (AT_CHECK_CONFIG_CREATION_NOWRITE): Skip
> no-write portion if user has root-like privileges.