[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Ignore errors from ./run on w32.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Ignore errors from ./run on w32. |
Date: |
Tue, 4 Mar 2008 22:43:37 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
Hi Eric,
* Eric Blake wrote on Tue, Mar 04, 2008 at 10:33:33PM CET:
>
> Another w32 oddity (tested on cygwin, but probably also present on
> mingw) is that with administrator privileges, you can rename and
> delete files into a read- only directory, even though you can't
> directly create one there. As such, test 122 was failing for me
> (config.status is able to unexpectedly create var-file in a temp
> directory, then move it to the read-only `.'). This patch skips the
> test if this root-like ability is present (which in turn probably
> fixes the problems that others reported when running the testsuite as
> root on a system with traditional Unix semantics).
I suppose then you did not see
<http://article.gmane.org/gmane.comp.sysutils.autoconf.patches/5346>
in which I was asking you about this? There is another proposed patch
in there, how about that one?
> I noticed that I couldn't do:
>
> some_test || AT_CHECK()
>
> since AT_CHECK() expands to "statements;" rather than "{ statements; }".
> Should we make AT_CHECK an inlineable statement group?
Sounds good to me.
Cheers,
Ralf
> From: Eric Blake <address@hidden>
> Date: Tue, 4 Mar 2008 14:28:54 -0700
> Subject: [PATCH] Ignore tests that require read-only directories under root.
>
> * tests/torture.at (AT_CHECK_CONFIG_CREATION_NOWRITE): Skip
> no-write portion if user has root-like privileges.