Re: [PATCH] Don't infloop upon "make dist".

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 3/2/2008 9:39 AM:
| I noticed that "make dist" would infloop.
| This change fixes that and syncs the pieces
| from coreutils and gnulib:
|
|       Don't infloop upon "make dist".
|       * GNUmakefile: Merge from coreutils.
|       * Makefile.am (dist-hook): Inject .tarball-version into tarball,
|       not .version.
|       * configure.ac (AC_INIT): Use .tarball-version, not .version.

No objections to the patch, per se, but a series of questions.  I'm trying
to figure out if I understand the difference between .version and
.tarball-version.  Are both files supposed to be present in a built
tarball, or just .version?  It looks like I have to manually create
.tarball-version with the desired version contents just prior to running
'make major' when using GNUMakefile (since 'make major' is run before the
tag is created, but git-version-gen needs either a file or an accurate
tag, so I supply the file)?  And the contents of .tarball-version are the
hint of what I plan on handing to 'git tag' after the make rule
successfully completes?  Otherwise, when not doing a formal release, I can
delete .tarball-version to fall back to the extra level of intra-release
version numbering?  Meanwhile, I never create .version manually; the
GNUMakefile and install-hook rules take care of it?  Likewise, when using
non-GNU make, the GNUMakefile rules aren't present, but 'make dist' is
adequate for .version to be sensible?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHyxye84KuGfSFAYARAptpAJwLIL5eQXJpWJiogqBOJzGRibC7kwCeI6mc
v2jjToTrrVMbmWuUEhO281Q=
=vjEo
-----END PGP SIGNATURE-----