[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Don't infloop upon "make dist".

From: Ralf Wildenhues
Subject: Re: [PATCH] Don't infloop upon "make dist".
Date: Sun, 2 Mar 2008 22:00:54 +0100
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

* Jim Meyering wrote on Sun, Mar 02, 2008 at 09:46:22PM CET:
> Ralf Wildenhues <address@hidden> wrote:
> >
> > Can you explain the infloop to me, because I have not experienced such
> > a loop.  Is that because I do not build in-tree?
> Perhaps.  That's the only way I've seen it.
> Try it in a srcdir build and you'll see for yourself.


> >> -# Copyright (C) 2001, 2003, 2006-2007 Free Software Foundation, Inc.
> >> +# Copyright (C) 2001, 2003, 2006-2008 Free Software Foundation, Inc.
> >
> > Please don't add ranges, but individual years, comma-separated.
> Yes, I know what GCS, lawyers, etc. prefer.
> Let's not worry about it.  I'm just syncing from coreutils.
> If it's a show-stopper for you, I'll change it in autoconf
> (but not in coreutils).

It's not a show-stopper.  But autotools are supposed to show good
example, so I try to remind people.

> >> -#
> >> +
> >
> > What's this good for except possibly interfering with a later scripted
> > change of many files' copyright statements (two instances)?
> Simply sync'd from coreutils.  I don't care.
> Which way would you like?

I don't care, it's merely that I wonder about seemingly unmotivated
changes (maybe there is a reason I didn't understand).

> >>    (cd $(srcdir) && autoreconf -i -v)      \
> >>      && rm -f INSTALL)
> >
> > Actually, this autoreconf invocation should have $build_tree/tests as
> > first $PATH entry, so that in-tree auto* are used if present.  I'm not
> Yes, we've been through this already :)
> You mean the ones that are used according to this PATH setting
> at the top of that file?
>     # Build with our own versions of these tools, when possible.
>     export PATH = $(shell echo "`pwd`/tests:$$PATH")

Argh.  Sorry about that.

The patch is ok with this change:  The _curr-ver computation needs to be

    _curr-ver := $(shell cd $(srcdir) && ./build-aux/git-version-gen \

because otherwise it won't work with a VPATH build.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]