[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spurious datarootdir warnings in Wine configure

From: Paul Eggert
Subject: Re: Spurious datarootdir warnings in Wine configure
Date: Thu, 22 Jun 2006 16:04:33 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Ralf Wildenhues <address@hidden> writes:

> +To help with the transition, some heuristics have been put in place that
> +warn about files which seem to lack a definition of @code{datarootdir},
> +and try to use an initialization not based on the new variable.

I got a bit confused with that.  How about this rewording?

  To help with the transition, Autoconf warns about makefiles that seem
  to use @code{datarootdir} without defining it.

(Or, if the heuristics aren't limited to makefiles, change "makefiles"
to "files" in the proposed rewording.)

> +# ...

These "# ..." lines aren't needed, surely.

> +The changes can usually be accomplished in a way that the resulting file
> +remains compatible with previous Autoconf versions:

Please reword to something like this:

  Usually one can easily change the makefile to accommodate both older
  and newer Autoconf releases:

> +to your @file{} to disable the warnings.  Note that for your own
> +macros, you should use a different prefix (@pxref{Macro Names}).

As Stepan suggested, that last sentence is confusing.  I'd replace it
with something like "This is an exception to the usual rule that you
should not define a macro whose name begins with @code{AC_}."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]