[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: clean up m4sh.m4, then optimize AS_PATH_WALK

From: Ralf Wildenhues
Subject: Re: clean up m4sh.m4, then optimize AS_PATH_WALK
Date: Tue, 4 Apr 2006 10:08:07 +0200
User-agent: Mutt/1.5.11

Hi Stepan,

* Stepan Kasal wrote on Tue, Apr 04, 2006 at 12:02:53AM CEST:
> > > > >       * lib/m4sugar/m4sh.m4 (_AS_PATH_WALK): Optimize nonexistent
> > > > >       directories, unless optional third argument supplied.
> > > > >       (AS_UNAME): Don't optimize PATH walk.
> On a second thought, I shouldn't have accepted that patch.
> If any caller needs to skip nonexistent directories, he can do so by
> insering the command
>       test -d "$ac_dir" || continue
> to the beginning of the second parameter.

Well.  There is a reason the macro name _AS_PATH_WALK starts with an
underscore, and is not documented: its interface is ugly as hell.
Let's do some interface cleanup post 2.60.

> So I'd like to back out Eric's patch, including the autotest fix that I
> added later.

I think this is ok if you back out Eric's comment change too, please
apply and check in a regenerated `configure'.


> 2006-04-03  Stepan Kasal  <address@hidden>
>       * lib/m4sugar/m4sh.m4 (_AS_PATH_WALK): Do not optimize; do not skip
>         nonexistent directories.
>       (_AS_DETECT_BETTER_SHELL): The optimization is moved here--try only
>         shell candidates which exist.
>       (AS_UNAME): No need to give three parameters to _AS_PATH_WALK.
>       * lib/autotest/general.m4 (AT_INIT): No need to give three parameters
>         to _AS_PATH_WALK.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]