[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Autotest: make test dir writable before removing

From: Ralf Wildenhues
Subject: Autotest: make test dir writable before removing
Date: Sat, 1 Oct 2005 21:12:43 +0200
User-agent: Mutt/1.5.9i

[ On followups, you can remove libtool-patches; it's merely FYI there ]

Background: we are working on a test in Libtool which itself tries a
`make distcheck'.  A failure in the test leaves non-writable files.
The next test run fails to clean up the test dir due to unwritable

This patch fixes that -- I'm not sure whether `chmod -R' is portable
enough though, but it's a lot less expensive than
  find $at_group_dir -exec chmod u+w \{\} \;
and I don't think you can expect file names within a test not to contain
white space.


        * lib/autotest/general.m4 (AT_INIT): Make test dir content
        writable before removing.

Index: lib/autotest/general.m4
RCS file: /cvsroot/autoconf/autoconf/lib/autotest/general.m4,v
retrieving revision 1.190
diff -u -r1.190 general.m4
--- lib/autotest/general.m4     23 Aug 2005 08:57:24 -0000      1.190
+++ lib/autotest/general.m4     1 Oct 2005 18:46:04 -0000
@@ -669,6 +669,7 @@
       # Create a fresh directory for the next test group, and enter.
+      chmod -R u+w $at_group_dir
       rm -f -r $at_group_dir
       mkdir $at_group_dir ||
        AS_ERROR([cannot create $at_group_dir])

reply via email to

[Prev in Thread] Current Thread [Next in Thread]