[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: A simplification of _AC_CANONICAL_SPLIT
From: |
Stepan Kasal |
Subject: |
Re: A simplification of _AC_CANONICAL_SPLIT |
Date: |
Wed, 17 Aug 2005 11:52:16 +0200 |
User-agent: |
Mutt/1.4.1i |
Hello,
On Tue, Aug 16, 2005 at 12:45:14PM -0700, Noah Misch wrote:
> > case $[#] in
> > + 0|1) set "";;
> > + *) shift; shift;;
> > esac
>
> This case statement now merely avoids shifting an empty argument list.
> Given that this code splits canonical platform names, which have three
> or more fields, why not just shift twice, unconditionally?
perhaps config.sub is broken, perhaps ac_cv_build came from config.site
or from a broken config.cache.
But yes, your idea is good: we can check that the variable has the
required form, and then remove the case statement.
Attached please find a patch which implements this. Moreover, it moves
more common code to _AC_CANONICAL_SPLIT.
OK to commit?
Stepan
autoconf-20050817-canonical-split.patch
Description: Text document
- A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/16
- Re: A simplification of _AC_CANONICAL_SPLIT, Noah Misch, 2005/08/16
- Re: A simplification of _AC_CANONICAL_SPLIT,
Stepan Kasal <=
- Re: A simplification of _AC_CANONICAL_SPLIT, Noah Misch, 2005/08/17
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/18
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/18
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/19
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/19
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/22
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/22
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/23
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/23
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/24