autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: loop in libtool m4 macros


From: Ralf Wildenhues
Subject: FYI: loop in libtool m4 macros
Date: Mon, 27 Jun 2005 16:55:18 +0200
User-agent: Mutt/1.4.1i

Hi Stepan,

* Stepan Kasal wrote on Mon, Jun 27, 2005 at 12:34:12PM CEST:
> On Wed, Jun 22, 2005 at 06:45:35PM +0200, Ralf Wildenhues wrote:
> 
*snip nice explanations*

> But:
> There are two cases when the second argument to m4_default is not
> double quoted; I think these should be fixed.
> 
> So I propose the following patch.

I agree, and have committed it to HEAD and branch-2-0.

Thanks!
Ralf

2005-06-27  Stepan Kasal  <address@hidden>

        * m4/ltsugar.m4 (lt_combine, _lt_combine): Fix default separator.

> Index: m4/ltsugar.m4
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/m4/ltsugar.m4,v
> retrieving revision 1.5
> diff -u -r1.5 ltsugar.m4
> --- m4/ltsugar.m4     17 Jun 2005 12:42:34 -0000      1.5
> +++ m4/ltsugar.m4     27 Jun 2005 10:23:09 -0000
> @@ -52,12 +52,12 @@
>  # has the form PREFIXmINFIXSUFFIXn.
>  m4_define([lt_combine],
>  [m4_if([$2], [], [],
> -       [lt_join(m4_quote(m4_default([$1], [, ])),
> +       [lt_join(m4_quote(m4_default([$1], [[, ]])),
>               _$0([$1], lt_car($2)[$3], m4_shiftn(3, $@)),
>               $0([$1], lt_cdr($2), m4_shiftn(2, $@)))])])
>  m4_define([_lt_combine],
>  [m4_if([$3], [], [],
> -       [lt_join(m4_quote(m4_default([$1], [, ])),
> +       [lt_join(m4_quote(m4_default([$1], [[, ]])),
>               [$2$3],
>               $0([$1], [$2], m4_shiftn(3, $@)))])[]dnl
>  ])
> 
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]