Re: Bug in AX_APPEND_LINK_FLAGS

[Mike Frysinger]

On Wednesday 01 January 2014 12:34:20 Peter Simons wrote:
> Hi Mike,
> 
> you submitted the following patch to AX_APPEND_LINK_FLAGS a while ago:
> 
>  
> http://git.savannah.gnu.org/cgit/autoconf-archive.git/commit/m4/ax_append_
> link_flags.m4?id=7d5e9315f7b93843f7d65699eebfec742323a483
> 
> Now, Peter De Wachter reports the following phenomenon:
>   > If you do something like:
>   >     AX_APPEND_LINK_FLAGS([--foo])
>   > 
>   > configure prints a bogus extra line:
>   >     checking whether the linker accepts ... yes
>   >     checking whether the linker accepts --foo... yes
>   > 
>   > This bug is introduced by commit 7d5e9315: serial 3 (the current
>   > version) has this bug, serial 2 not.
> 
> Do you, by any chance, have an idea how to explain and/or remedy this
> behavior?

blah, it's because i misused the AC_REQUIRE helper.  it not only makes sure 
the func is available, but then also calls it.  i don't know of a way to get 
the desired behavior (an m4 error when the macro isn't available) other than 
AC_REQUIRE.

so the options are:
 - have AX_APPEND_FLAG do nothing when $1 is not set
 - revert my change
-mike

signature.asc
Description: This is a digitally signed message part.