[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [AUCTeX] Small optimizations / was: Problem with latex2e style hook
From: |
Tassilo Horn |
Subject: |
Re: [AUCTeX] Small optimizations / was: Problem with latex2e style hook --- LaTeX/Texinfo collision |
Date: |
Tue, 19 Aug 2014 07:58:04 +0200 |
User-agent: |
Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (gnu/linux) |
Vincent Belaïche <address@hidden> writes:
Hi Vincent,
>> sorry, I've forgotten to mention in my last mail that the patch won't
>> apply cleanly. Looking at the diff for ChangeLog, it seems it's based
>> on some quite old version. Could you update it to apply on the
>> current git head, please?
>
> Done (see attachment), sorry for the inconvenience. I also noticed
> that there were other files with the (make-local-variable 'foo) (setq
> foo ...) not optimized, so for consistency I did it everywhere.
Great, thanks.
>> It also contains trailing whitespace which it shouldn't (and git
>> won't apply by default).
>
> I did some `M-x edit-picture' + `C-c C-c' on all the modified
> files. So no more tailing blanks.
M-x delete-trailing-whitespace RET would also have worked.
> BTW, in my previous contributions the git commits were with
> address@hidden, which a git log does show, although
> the ChangeLog is with my address @sourceforge. I think that you should
> keep it this way for git repo consistency (maybe we change the
> ChangeLog some day which is easier, so for git please keep the same
> author). Sorry for introducing this who-I-am discrepancy.
Sorry, I don't get you exactly. Should I commit with your sf or hotmail
address?
> diff --git a/ChangeLog b/ChangeLog
> index 791a5a1..94dcf6e 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,47 @@
> +2014-08-18 Vincent Belaïche <address@hidden>
> +
> + * tex.el :
I think there's something missing here. (Or not, seems to be just a
left-over duplicate...)
Bye,
Tassilo