[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [AUCTeX-devel] Bunch of patches
From: |
Tassilo Horn |
Subject: |
Re: [AUCTeX-devel] Bunch of patches |
Date: |
Mon, 15 Apr 2013 17:07:15 +0200 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) |
Mosè Giordano <address@hidden> writes:
Hi Mosè,
> can I commit the attached patches?
Yes, they all look good to me. There's one minor nitpick below.
> diff --git a/style/acro.el b/style/acro.el
> index 61b57a0..8ced532 100644
> --- a/style/acro.el
> +++ b/style/acro.el
> @@ -139,24 +139,17 @@ in its optional argument.")
>
> (defun LaTeX-arg-acro-key-val (optional prompt key-val-alist)
> "Prompt for keys and values in KEY-VAL-ALIST.
> -<SPC> key bindings in minibuffer are removed temporarily. Insert
> +<SPC> key binding in minibuffer is removed temporarily. Insert
> the given value as a TeX macro argument. If OPTIONAL is non-nil,
> insert it as an optional argument. Use PROMPT as the prompt
> string. KEY-VAL-ALIST is an alist. The car of each element
> should be a string representing a key and the optional cdr should
> be a list with strings to be used as values for the key."
> - ;; Remove <SPC> key bindings in minibuffer.
> - (let ((space-completion (lookup-key minibuffer-local-completion-map " "))
> - (space-must-match (lookup-key minibuffer-local-must-match-map " ")))
> - (define-key minibuffer-local-completion-map " " nil)
> - (define-key minibuffer-local-must-match-map " " nil)
> - (let ((var (multi-prompt-key-value
> - (TeX-argument-prompt optional "Options (k=v)" prompt)
> - (eval key-val-alist))))
> - (TeX-argument-insert var optional))
> - ;; Restore <SPC> key bindings in minibuffer.
> - (define-key minibuffer-local-completion-map " " space-completion)
> - (define-key minibuffer-local-must-match-map " " space-must-match)))
> + ;; Remove <SPC> key binding from map used in `multi-prompt-key-value'
> (called
> + ;; by `TeX-arg-key-val') with `require-match' set to `nil'.
> + (let* ((crm-local-completion-map
> + (remove (assoc 32 crm-local-completion-map)
> crm-local-completion-map)))
> + (TeX-arg-key-val optional key-val-alist prompt)))
A plain `let' would suffice here.
Bye,
Tassilo