[Antiright-devel] antiright configure gshterm/command_line.c gsht... [antiright-3]

[Jeffrey Bedard]

CVSROOT:        /sources/antiright
Module name:    antiright
Branch:         antiright-3
Changes by:     Jeffrey Bedard <jefbed> 07/03/07 03:58:35

Modified files:
        .              : configure 
        gshterm        : command_line.c main.c 
        gtkshell       : arguments.c dialog_options.c dragdrop.c 
                         file_dialog.c file_dialog.h font.c font.h 
                         gtkshell.h text.c 

Log message:
        Increased warning level and fixed warnings.  

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/antiright/configure?cvsroot=antiright&only_with_tag=antiright-3&r1=1.81.2.1&r2=1.81.2.2
http://cvs.savannah.gnu.org/viewcvs/antiright/gshterm/command_line.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.7&r2=1.7.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gshterm/main.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.13&r2=1.13.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/arguments.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.12&r2=1.12.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/dialog_options.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.10&r2=1.10.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/dragdrop.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.8&r2=1.8.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/file_dialog.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.5&r2=1.5.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/file_dialog.h?cvsroot=antiright&only_with_tag=antiright-3&r1=1.4&r2=1.4.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/font.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.3&r2=1.3.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/font.h?cvsroot=antiright&only_with_tag=antiright-3&r1=1.2&r2=1.2.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/gtkshell.h?cvsroot=antiright&only_with_tag=antiright-3&r1=1.22&r2=1.22.2.1
http://cvs.savannah.gnu.org/viewcvs/antiright/gtkshell/text.c?cvsroot=antiright&only_with_tag=antiright-3&r1=1.16&r2=1.16.2.1

Patches:
Index: configure
===================================================================
RCS file: /sources/antiright/antiright/configure,v
retrieving revision 1.81.2.1
retrieving revision 1.81.2.2
diff -u -b -r1.81.2.1 -r1.81.2.2
--- configure   5 Mar 2007 23:42:01 -0000       1.81.2.1
+++ configure   7 Mar 2007 03:58:35 -0000       1.81.2.2
@@ -34,6 +34,9 @@
        if [ "$ARG" = "-d" ]; then
                echo 'Configuring with debug options...'
                CFLAGS="$CFLAGS -g3 -Wall -W -Werror -DDEBUG"
+               CFLAGS="$CFLAGS -Wwrite-strings "
+               CFLAGS="$CFLAGS -Wsign-compare -Wunreachable-code"
+               CFLAGS="$CFLAGS -Wmissing-noreturn -Wmissing-declarations"
        elif [ "$ARG" = "-l" ]; then
                PREFIX=/usr/local/packages/antiright
        elif [ "$ARG" = "-s" ]; then

Index: gshterm/command_line.c
===================================================================
RCS file: /sources/antiright/antiright/gshterm/command_line.c,v
retrieving revision 1.7
retrieving revision 1.7.2.1
diff -u -b -r1.7 -r1.7.2.1
--- gshterm/command_line.c      28 Feb 2007 03:53:51 -0000      1.7
+++ gshterm/command_line.c      7 Mar 2007 03:58:35 -0000       1.7.2.1
@@ -27,7 +27,7 @@
 {
        gchar *command;
 
-       command = "";           /* Initialize to empty for the first
+       command = (gchar*)"";           /* Initialize to empty for the first
                                 * concatenation.  */
 
        ARIFNB(gshterm_construct_command_from_args(
@@ -45,9 +45,9 @@
        return (command);
 }
 
-gboolean
-gshterm_handle_command_line_option(
-                     struct GSHTerm * term, gchar option, gchar *arg)
+static gboolean
+gshterm_handle_command_line_option(struct GSHTerm * term, 
+                                  gchar option, gchar *arg)
 {
        ARIFNP(arg)
        {

Index: gshterm/main.c
===================================================================
RCS file: /sources/antiright/antiright/gshterm/main.c,v
retrieving revision 1.13
retrieving revision 1.13.2.1
diff -u -b -r1.13 -r1.13.2.1
--- gshterm/main.c      28 Feb 2007 03:53:51 -0000      1.13
+++ gshterm/main.c      7 Mar 2007 03:58:35 -0000       1.13.2.1
@@ -24,7 +24,7 @@
 #include <unistd.h>
 
 
-struct GSHTerm *
+static struct GSHTerm *
 gshterm_init_and_script(int *argc, char ***argv)
 {
        struct GSHTerm *term;

Index: gtkshell/arguments.c
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/arguments.c,v
retrieving revision 1.12
retrieving revision 1.12.2.1
diff -u -b -r1.12 -r1.12.2.1
--- gtkshell/arguments.c        5 Mar 2007 16:28:14 -0000       1.12
+++ gtkshell/arguments.c        7 Mar 2007 03:58:35 -0000       1.12.2.1
@@ -43,22 +43,12 @@
                gsh_command_button(gsh, string);
 
        g_strfreev(pair);
-
-       //gsh->rows.row--;
-}
-static void
-activate_cb(GtkWidget * widget, gpointer data)
-{
-       const gchar * command;
-       command=(const gchar *)data;
-       ARBUG((gchar *)command);
-       antiright_system((char *)command);
 }
+
 static void
 menuitem_parse(struct GSH * gsh, gchar * string)
 {
        gchar **pair;
-       GtkWidget * item;
        gchar * command;
 
        pair=g_strsplit(string, ",", 2);
@@ -95,7 +85,6 @@
        if(ARPBOOL(tokens[1]))
        {
                GtkWidget * oldrow;
-               GtkWidget * button;
 
                oldrow=gsh->rows.v;
 

Index: gtkshell/dialog_options.c
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/dialog_options.c,v
retrieving revision 1.10
retrieving revision 1.10.2.1
diff -u -b -r1.10 -r1.10.2.1
--- gtkshell/dialog_options.c   28 Feb 2007 03:53:51 -0000      1.10
+++ gtkshell/dialog_options.c   7 Mar 2007 03:58:35 -0000       1.10.2.1
@@ -23,6 +23,27 @@
 #include "gtkshell.h"
 
 static void
+gsh_message_dialog(struct GSH * gsh, 
+                  GtkMessageType type, 
+                  char *text) __attribute__((noreturn));
+
+static void
+gsh_setup_message_dialog(struct GSH * gsh, 
+                        int argc, char **argv,
+                        unsigned int *counter, 
+                        GtkMessageType type) __attribute__((noreturn));
+
+static void
+gsh_font_dialog() __attribute__((noreturn));
+
+static void
+gsh_color_dialog() __attribute__((noreturn));
+
+static void
+gsh_about_dialog() __attribute__((noreturn));
+
+
+static void
 gsh_message_dialog(struct GSH * gsh, GtkMessageType type, char *text)
 {
        GtkWidget *dialog;

Index: gtkshell/dragdrop.c
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/dragdrop.c,v
retrieving revision 1.8
retrieving revision 1.8.2.1
diff -u -b -r1.8 -r1.8.2.1
--- gtkshell/dragdrop.c 2 Mar 2007 19:12:00 -0000       1.8
+++ gtkshell/dragdrop.c 7 Mar 2007 03:58:35 -0000       1.8.2.1
@@ -30,9 +30,9 @@
        TARGET_STRING
 };
 
-static GtkTargetEntry target_list[] =
+static const GtkTargetEntry target_list[] =
 {
-       {"text/plain", 0, TARGET_STRING}
+       {(gchar*)"text/plain", 0, TARGET_STRING}
 };
 
 static guint n_targets = G_N_ELEMENTS(target_list);

Index: gtkshell/file_dialog.c
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/file_dialog.c,v
retrieving revision 1.5
retrieving revision 1.5.2.1
diff -u -b -r1.5 -r1.5.2.1
--- gtkshell/file_dialog.c      28 Feb 2007 03:53:51 -0000      1.5
+++ gtkshell/file_dialog.c      7 Mar 2007 03:58:35 -0000       1.5.2.1
@@ -21,7 +21,6 @@
 */
 #include "gtkshell.h"
 
-
 /* Taken from the GTK+ Reference Manual */
 void
 gsh_file_dialog(struct GSH * gsh, GtkFileChooserAction action)

Index: gtkshell/file_dialog.h
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/file_dialog.h,v
retrieving revision 1.4
retrieving revision 1.4.2.1
diff -u -b -r1.4 -r1.4.2.1
--- gtkshell/file_dialog.h      28 Feb 2007 03:53:51 -0000      1.4
+++ gtkshell/file_dialog.h      7 Mar 2007 03:58:35 -0000       1.4.2.1
@@ -22,15 +22,21 @@
 
 #ifndef GSH_FILE_DIALOG
 #define GSH_FILE_DIALOG
+
 void
-     gsh_file_dialog(struct GSH * gsh, GtkFileChooserAction action);
+gsh_file_dialog(struct GSH * gsh, 
+               GtkFileChooserAction action) __attribute__((noreturn));
+
 void
-     gsh_file_open_dialog(struct GSH * gsh);
+gsh_file_open_dialog(struct GSH * gsh) __attribute__((noreturn));
+
 void
-     gsh_file_save_dialog(struct GSH * gsh);
+gsh_file_save_dialog(struct GSH * gsh) __attribute__((noreturn));
+
 void
-     gsh_folder_open_dialog(struct GSH * gsh);
+gsh_folder_open_dialog(struct GSH * gsh) __attribute__((noreturn));
+
 void
-     gsh_folder_create_dialog(struct GSH * gsh);
+gsh_folder_create_dialog(struct GSH * gsh) __attribute__((noreturn));
 
-#endif
+#endif /* !GSH_FILE_DIALOG */

Index: gtkshell/font.c
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/font.c,v
retrieving revision 1.3
retrieving revision 1.3.2.1
diff -u -b -r1.3 -r1.3.2.1
--- gtkshell/font.c     28 Feb 2007 03:53:51 -0000      1.3
+++ gtkshell/font.c     7 Mar 2007 03:58:35 -0000       1.3.2.1
@@ -23,7 +23,7 @@
 #include "gtkshell.h"
 
 void
-gsh_widget_set_font(GtkWidget *widget, gchar *font)
+gsh_widget_set_font(GtkWidget *widget, const gchar *font)
 {
        PangoFontDescription *font_desc;
 

Index: gtkshell/font.h
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/font.h,v
retrieving revision 1.2
retrieving revision 1.2.2.1
diff -u -b -r1.2 -r1.2.2.1
--- gtkshell/font.h     28 Feb 2007 03:53:51 -0000      1.2
+++ gtkshell/font.h     7 Mar 2007 03:58:35 -0000       1.2.2.1
@@ -24,7 +24,7 @@
 #define GTKSHELL_FONT_H
 
 void
-     gsh_widget_set_font(GtkWidget *widget, gchar *font);
+     gsh_widget_set_font(GtkWidget *widget, const gchar *font);
 
 void
      gsh_widget_set_font_mono(GtkWidget *widget);

Index: gtkshell/gtkshell.h
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/gtkshell.h,v
retrieving revision 1.22
retrieving revision 1.22.2.1
diff -u -b -r1.22 -r1.22.2.1
--- gtkshell/gtkshell.h 4 Mar 2007 23:23:20 -0000       1.22
+++ gtkshell/gtkshell.h 7 Mar 2007 03:58:35 -0000       1.22.2.1
@@ -93,4 +93,10 @@
 GtkWidget *
 gsh_create_main_window();
 
-#endif
+void
+gsh_GSH(struct GSH * gsh);
+
+struct GSH *
+gsh_new_GSH();
+
+#endif /* !GSH_GTKSHELL_H */

Index: gtkshell/text.c
===================================================================
RCS file: /sources/antiright/antiright/gtkshell/text.c,v
retrieving revision 1.16
retrieving revision 1.16.2.1
diff -u -b -r1.16 -r1.16.2.1
--- gtkshell/text.c     5 Mar 2007 01:05:42 -0000       1.16
+++ gtkshell/text.c     7 Mar 2007 03:58:35 -0000       1.16.2.1
@@ -42,7 +42,7 @@
                cb->data = command;     /* Static storage, will not
                                         * pass out of scope.  */
        else
-       cb->data = "echo";      /* Literal */
+               cb->data = (gpointer)"echo";    /* Literal */
 
        /* Create widget.  */
        entry = gtk_entry_new();