[wdiff-dev] [patch #7121] New, per-character diff, mode

[Martin von Gagern]

Update of patch #7121 (project wdiff):

                  Status:                    None => Need Info              

    _______________________________________________________

Follow-up Comment #2:

OK, I've now had a second look at your patch. The general idea seems sane
enough. A few remarks, in order of diff lines:

* Would it be all right to move your name from the source file to the AUTHORS
file in the long run? Generally, the change is a significant one. Would you be
willing to assign the copyright for your modifications to the Free Software
Foundation, so that we can officially include it in future releases? If so,
I'll send you suitable forms by e-mail.

* The "c" short option is used by mdiff for context format, but as wdiff
doesn't support context format, that should be all right. The introduction of
a new flag means we'll need additional translations. Therefore I won't include
this in any 0.6.x release, but rather target this towards 0.7.0.

* The UTF-8 treatment is very simplistic. I'd either want it to check UTF-8
format more thoroughly, i.e. calculate number of bytes to expect and ensure
that's what we get, or I'd want it enabled only in UTF-8 locales. The former
has benefits when file encoding doesn't agree with default locale encoding,
but prevents users from overriding this using environment variables. I guess
getting things right in non-UTF multibyte encodings might be a lot harder, but
I'd like to know just how hard.

* Maybe we can avoid some duplication, e.g. between get_char and skip_char,
or between copy_char and copy_word. Haven't tried to yet, so I'm not sure it
would make sense.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7121>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/