[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
More nits
|
From: |
Yavor Doganov |
|
Subject: |
More nits |
|
Date: |
Wed, 27 Feb 2008 11:47:10 +0000 |
On ср, 2008-02-27 at 10:49 +0000, Kaloian Doganov wrote:
> * validate-html-notify: New file: mails output of a failed
> command.
> * mailfail: New file: runs `validate-html' through `mailfail'.
Isn't this exactly the opposite?
> +if [[ "$1" == "--dry-run" ]]; then
Double brackets here.
> +if [[ "$1" == "--dry-run" ]]; then
Likewise.
> +if [[ ( -z "$DRY_RUN" ) && ( "$CMDSTATUS" -ne 0 ) ]]; then
> + mail "$RCPT" --subj "$SUBJECT" < "$TMP"
> +fi
Isn't the standard way of doing this
if [ condition A ] && [ condition B ]; then
At least this is what I've encountered so far.