Re: [Tlf-devel] Stew Perry review

[Ervin Hegedüs]

Hello Pat,

On Thu, Jan 23, 2014 at 09:11:53PM -0500, Pat Collins wrote:
> On Thu, 23 Jan 2014 22:29:33 +0100 Ervin Hegedüs - HA2OS <address@hidden>
> wrote
> 
> > there is a new keyword: POWERMULT, and it needs an argument,
> > which will be used as integer, and calculated score will be
> > multiply with this value. For example: if you put 4 to there, the
> > score multiplier will be 4, if you put 11, that will be... :) You
> > can decide which is good for you - in this case this keyword
> > could be more flexible.
> > 
> Probably want to make that a double.  I think 1.5 is a possible value.

so, I reviewed the code, and looks like this is more complicated
than it first seemed.

The problem is the "points" type in Tlf is int. That would be
double, but then it must to show that format, eg. 1250.5 - but if
there isn't any N.5 multiplier or other modifier, which eventuate
non-double result, the points are showing as double too, eg.
1250.0 :( 

And it would be too hard work to modify all places, and - it's
more important - validate the result, so that type change is
working correctly...


If anybody has a good idea, how could we result this, just let me
know...
 
> > The placeholder for the MYQRA is a littlebit more complex -
> > because I don't know, which character should be used for that?
> > 
> > These are busy: %, @, #, [, +, -
> > 
> > Usable: *, ~, ^, `, ', ", !, (, ), <, >, &, {, }, ...
> > 
> > Which one is the best choice for the MYQRA?
> > 
> 
> This is probably part of tlf that needs rewritten.  It would be nice to have
> common replacements like @, #, %, but also more complex ones like {myqra} so 
> we
> could be more flexible and maybe have user defined items.  
> 
> I'd be glad to take that on if we think it is useful.

as you can see, we discussed it with Thomas, and he wrote, the
MYQRA is a constant, and not need to substitute that.



73,

Ervin
HA2OS 

-- 
I � UTF-8