Re: [STUMP] Windowlist completion

[Ben Spencer]

On Sun, Nov 13, 2011 at 09:16:07PM -0600, Krzysztof Drewniak wrote:
> I think we should remove the "j" and "k" bindings because they violate
> the principle of least astonishment. It is probably really confusing (as
> a user) that every "normal" (alphanumeric) key adds to the search
> string, EXCEPT "j" and "k", which clear the search string and move the
> selection.

Ok, nobody spoke out in their favour, they're gone.


> I have attached a patch that implements this feature.
> > 
> I have attached a patch which implements this as well.
> > 
> While testing my Backspace patch, I discovered a bug: pressing Page Up
> of Page Down with *menu-maximum-height* set to nil causes the error
> "Argument Y is not a number: NIL". A patch which fixes this issue is
> attached.

All looks great and has been pushed.  Thanks :)


Ben