Re: [STUMP] Menu scrolling

[Ben Spencer]

On Sun, Feb 13, 2011 at 02:51:00PM -0500, Vitaly Mayatskikh wrote:
> I want to give another spin to patch which Morgan posted here 2 or 3
> years ago. This patch adds ability to make menus scrollable, if all
> contents can not fit into menu.
> 
> For example, with vanilla StumpWM when you open large mpd collection
> menu (with contribs/mpd.lisp), the menu window stretches far away the
> screen. After you apply patch you'll see nice cute small menu which
> scroll up and down when cursor reaches the borders.
> 
> I use this patch since the very beginning and did not notice even
> single problem.
> 
> If there's no objections, I'll commit it finally.

Hi,

The feature looks cool but I found the code a little hard to read.
Attached is a patch that tidies it up a bit.  I've also exported the
two new variables, removed an apparently obsolete TODO, and added back
in a binding of *current-menu-input* that seems to have been
unintentionally removed.

I've given this some basic testing and it looks fine but I don't use
mpd.lisp so I'd appreciate you giving it a go with that.

Ben

menu-scroll.diff
Description: Text Data