Re: [STUMP] [PATCH] Improved window-head for floating windows.

[Shawn Betts]

On Sat, Oct 24, 2009 at 6:34 AM, Ben Spencer <address@hidden> wrote:
> At least, I think it's an improvement.  Not 100% certain this won't
> break anything elsewhere.  Thoughts?

Technically, I have 2 minor suggestions. Make get-overlap a local
function with labels, since it appears to be a utility function used
only in one place. And use dolist's built in result-form:

(dolist (var list-form [result-form]) ...)

Although it could be argued that explicitely returning best-head is
easier to understand. Somehow I want to see this written as a loop
macro instead of a bunch of let blocks and dolist but alas I can't
think of a way to do it that's any more succinct.

conceptually, I don't know that the head should be calculated based on
what head it most overlaps. I usually think of a window's top left
corner dictating what head it's on. That said, the idea of trying to
assign one head to a window that can be in up to 4 heads is also a bit
flawed. Perhaps the Rightest of right things to do is to examine what
code uses group-head and see if it can be eliminated or in someway
abstracted to better capture what is going on in float mode. But that
seems hard and stuff :).

-Shawn