Re: [STUMP] [PATCH] Fixed bug in kill-group when there is only one visible group remaining

[Shawn]

Lionel Flandrin <address@hidden> writes:

> * kill-group now checks if "to-group" is not the same as the group to
>   be deleted. Checking if the total number of groups is > 1 is not
>   enough since the other groups can be hidden, and in this case
>   next-group == current-group. This caused the windows to be sent to a
>   deleted group, never to be found again...
> ---
>  group.lisp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/group.lisp b/group.lisp
> index 424dc88..171ae9a 100644
> --- a/group.lisp
> +++ b/group.lisp
> @@ -173,7 +173,7 @@ at 0. Return a netwm compliant group id."
>                                     :cardinal 32))))
>  
>  (defun kill-group (group to-group)
> -  (when (> (length (screen-groups (group-screen group))) 1)
> +  (unless (eq group to-group)
>      (let ((screen (group-screen group)))
>        (merge-groups group to-group)
>        (setf (screen-groups screen) (remove group (screen-groups screen)))

Applied. Thanks!

-Shawn