speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/3] fix uninitialized status_info


From: Andrei Kholodnyi
Subject: [PATCH 2/3] fix uninitialized status_info
Date: Thu, 30 Sep 2010 01:05:55 +0200

status_info could be uninitialized by module_init
which could cause a crash while printing it.
set it to default message if uninitialized.

Thanks Halim Sahin for reporting this problem
---
 src/modules/module_main.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/modules/module_main.c b/src/modules/module_main.c
index 30c3f38..b50d72a 100644
--- a/src/modules/module_main.c
+++ b/src/modules/module_main.c
@@ -77,7 +77,7 @@ main(int argc, char *argv[])
     int ret_init;
     size_t n;
     char *configfilename;
-    char *status_info;        
+    char *status_info = NULL;
 
     g_thread_init(NULL);
 
@@ -117,6 +117,10 @@ main(int argc, char *argv[])
     
     ret_init = module_init(&status_info);
 
+    if (status_info == NULL) {
+        status_info = g_strdup("unknown, was not set by module");
+    }
+
     cmd_buf = NULL;  n=0;
     ret = spd_getline(&cmd_buf, &n, stdin);
     if (ret == -1){
-- 
1.6.0.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]