speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Add a portable implementation of getline to src/common.


From: Andrei Kholodnyi
Subject: [PATCH] Add a portable implementation of getline to src/common.
Date: Tue, 28 Sep 2010 17:26:44 +0200

here are my comments.

+#ifndef SPD_UTILS_H
+#define SPD_UTILS_H
+ssize_t spd_getline(char **lineptr, size_t * n, FILE * f);
+#endif /* SPD_UTILS_H */

includes should be added since size_t and FILE are used
#include <stdio.h>
#include <stddef.h>

+ * getline.c - portable implementation of getline
spd_getline.c, not getline.c

and I'd rather rename source file into spd_getline.c to follow function naming.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]