speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] merge SPDNotification into SPDNotificationType


From: Christopher Brannon
Subject: [PATCH] merge SPDNotification into SPDNotificationType
Date: Mon, 27 Sep 2010 06:58:33 -0500

Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:

>  typedef enum{
> -    SPD_BEGIN = 1,
*SNIP*
> +    SPD_EVENT_BEGIN = 1,

My inclination is to put this aside for a while.
It breaks backward compatibility, requiring both a soname bump and
possible changes to existing clients.  Of course, I'm always willing to
go against my inclinations, given a good reason to do so.

> +    SPD_EVENT_ALL = 0x3F

I really like this!  I would write it differently:
SPD_EVENT_ALL = SPD_EVENT_BEGIN | SPD_EVENT_END | ... | SPD_EVENT_RESUME;
But that's a matter of style.

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100927/fa1b85cd/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]