speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Convert src/modules to use GLib memory management exclusively.


From: Christopher Brannon
Subject: [PATCH] Convert src/modules to use GLib memory management exclusively.
Date: Fri, 24 Sep 2010 14:50:33 -0500

Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:

> I have added in the first patch following comment:
>
>     spd_malloc and friends are replaced with corresponding glib calls
>
> Besides that I have fixed whitespace errors in both patches.
> If you agree with these changes I can push them.

Those are good.  Thanks!  More patches are on the way: audio subsystem,
common library, and API.

> we have
> spd_fdset_copy(TFDSetElement old)
>      TFDSetElement new;
> ...
>      return new;
>
> where new is a function's local struct.

This is perfectly legit.  The struct is returned by value.  It is
copied.  Thus, we aren't returning data that has gone out of scope.

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100924/6aa7c00a/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]