[PATCH] Rework the do_list_voices function, and fix a memory leak.

[Trevor Saunders]

Hi,

On Fri, Sep 17, 2010 at 05:43:34PM +0200, Andrei Kholodnyi wrote:
> Hi Trev
> 
> > I believe we can trust that name != NULL because that list of voices
> > came from the module which we can trust. ?I believe we can trust modules
> > because currently for the module to be running someone trusted with the
> > right to edit the speechd.conf has to set it up to run, so if they can
> > setup a militious module we were already owned, and they have no reason
> > to add such a module. ?If we support runtime or automatic module loading
> > only modules in a system folder like /usr/lib/speech-dispatcher-modules
> > should be loaded, not any module, which means we can trust the module
> > because someone needs permissions to write there to add a module.
> >
> > I hope I'm clear enough on why this shouldn't be an issue.
> 
> Yes, but still there is an issue here.
> The voice list is generated by software outside of speech dispatcher
> /festival, espeak etc./ and delivered to your "trusted" spd module.
> 
> That's why I think this check is valid here.

yes, good point.  Also there is nothing to be gained by trusting the
module will check that for us.
Trev

> 
> Andrei.
> 
> _______________________________________________
> Speechd mailing list
> Speechd at lists.freebsoft.org
> http://lists.freebsoft.org/mailman/listinfo/speechd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100917/7ca617f9/attachment.pgp>