[PATCH] Memory leak in module_utils.c

[Christopher Brannon]

jose vilmar estacio de souza <vilmar at informal.com.br> writes:

> The function do_list_voices creates a GString to format the list of voices.
> After the creation, the function returns the character data of the string
> but does not free the memory allocated for the GString.

Hi Jose,
I'd really like to be able to apply this patch!
Unfortunately, it doesn't apply to either of our public branches, and I
don't know which commit is the head in your personal clone.
When you send a patch, please make sure it applies cleanly against
master.  My advice is to do your work on a personal branch, and then
keep that branch rebased.
I can resend your patch after applying it manually.

For future reference, I'd also suggest
g_string_free(voice_list, FALSE);
instead of
g_string_free(voice_list, 0);
Using the FALSE and TRUE constants makes it a little more clear that the
second argument is a boolean.  That's pure nitpicking on my part.

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100913/f59f3c31/attachment.pgp>