[PATCH] added support for get_playcmd in libao

[Bohdan R . Rau]

On Sat, 4 Sep 2010 17:43:44 -0400, Trevor Saunders
<trev.saunders at gmail.com> wrote:
> Hi,
> 
>>    However I have a question concerning generic module.
>>    Why do we use command line commands like aplay?
>>    is it not better to read file generated by synth in the generic
>>    module and
>>    then send it to the audio plugin for play?
> 
> this seems reasonable to me, but I'd probably use a piperather than a
> file.

As for me it should be configurable.

a) external syntesizer uses it's own audio system (like hardware
snthesizers) - nothing is needed, but we should provide something like
"STOP" command instead of kill. I don't use hardware synthesizers and have
no acces to them - so I can't help. 

b) synthesizer can only write wave to file - we must put the filename into
configuration and pass it to synth. In this case audio module should play
this file (probably unlinking it just after open). Probably there is rather
rare case when synthesizer can produce only raw audio data in specific
file... should we care about it?

c) synthesizer can produce wave or raw audio on its stdout. In this case
we must configure audio type (wave, raw, and all parameters in case of raw
audio).


>  While non of them are too terrible I have some security concerns
> with using a file.  We have to be careful about permissions no big deal
> but has to be done.  We have to make sure the disk doesn't get filed
> with one audio file if the message is too long.

...like in current generic module? :)

Some weeks ago I wrote something in this topic... I don't remember on
which list (speechd/opentts)? For me the input for generic module also
should be configurable - the synthesizer may use pipe to read all data on
its stdin, or may require data given as argument. By the way - the caller
should not simply replace pseudo-variables in GenericSynth string but use
real environment (for example to use these variables directly in shell
scripts, python programs or something).

So - may be the generic module should be totally rewritten?

ethanak
-- 
http://milena.polip.com/ - Pa pa, Ivonko!