On Tue, Aug 09, 2005 at 10:15:25AM -0400, Jason Harris wrote:
> On Mon, Aug 08, 2005 at 09:14:53PM -0400, Yaron Minsky wrote:
>
> > I just committed a version of Jason's patch to my mainline tree. Any other
> > patches not there that people think worth of inclusion before I bless
> > another release?
>
> First, don't forget the patch from:
>
> Date: Mon, 25 Apr 2005 15:44:42 -0400
> From: Jason Harris <address@hidden>
> To: address@hidden
> Subject: Re: [Sks-devel]
keyserver.linux.it - Error parsing headers: no colon found
> Message-ID: <address@hidden>
I'll dig this one out.
> Second, address@hidden/sks--mainline--1.0--patch-40
> probably doesn't work (or at least shouldn't). The strings are
> normally "keytext=" or "keytext%3D" (as currently hex-escaped by
> GPG+libcurl). The "3D" should (if not MUST) be removed from the input
> to Armor.decode_pubkey().
Got it. I fixed it by just applying Wserver.decode to the whole
of body before doing the rest. Take a look at patch-41 and see if
you like it better.
> NB: I now see that pks hex-decodes the entire thing before doing its
> (albeit case-insensitive) comparison with "keytext=" - this is probably
> best for SKS too.
Even more so, I believe that (while no program currently does this to
my knowledge), it is legal for the contents of keytext (i.e. the key
data itself) to be %-escaped as well. Case insensitive is incorrect
though. No harm in this case, but pksd shouldn't do that.
David
_______________________________________________
Sks-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/sks-devel