sed-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 3 more tests


From: Jim Meyering
Subject: Re: 3 more tests
Date: Sat, 16 Jul 2016 22:46:52 -0700

On Sat, Jul 16, 2016 at 5:59 PM, Assaf Gordon <address@hidden> wrote:
> Attached are the last 3 tests in my 'queue':
> Assaf Gordon (3):
>   tests: test y,s non-slash multibyte delimiters
>   tests: test y command in multibyte locales
>   tests: test --follow-symlinks option
>
>  configure.ac                 |   2 +
>  testsuite/Makefile.am        |   8 ++-
>  testsuite/follow-symlinks.sh |  74 ++++++++++++++++++++++++
>  testsuite/mb-bad-delim.sh    |  84 +++++++++++++++++++++++++++
>  testsuite/mb-y-translate.sh  | 135 
> +++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 302 insertions(+), 1 deletion(-)
>  create mode 100644 testsuite/follow-symlinks.sh
>  create mode 100755 testsuite/mb-bad-delim.sh
>  create mode 100755 testsuite/mb-y-translate.sh
>
> They test existing functionality, no code changes, and are mainly for more 
> complete code coverage.

Thanks a lot. I spotted only nits:
 "tests: test y command in multibyte locales" had two comment typos:
s/ivalid/invalid/ and s/des\.t/dest./

With those fixed, please push.

> When these are done, the next step could be the non-recursive makefile patch.

Looking forward to it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]