[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: untranslatable error string in compile.c
From: |
Jim Meyering |
Subject: |
Re: untranslatable error string in compile.c |
Date: |
Fri, 3 Jun 2016 21:54:58 -0700 |
On Fri, Jun 3, 2016 at 7:02 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>
> Commit 854b64 [1] (which I suggested about a year ago) had an unintended
> effect:
>
> It makes the last error message untranslatable, because nowhere is it passed
> to gettext's N_() macro.
>
> In the current repository that message is "recursive escaping after \\c not
> allowed" [2],
> and it does not appear in 'po/sed.pot' as a result.
>
> The attached patch uncomments the unused macro END_ERRORS, then the string
> does appear in po/sed.pot.
>
> Not sure if this is the optimal way.
> Comments welcomed,
Glad you caught that before release.
Your fix looks fine.
Please capitalize the first word of sentences in the commit log. i.e.,
s/un/Un/ in this line:
* sed/compile.c: (END_ERRORS): uncomment unused macro, required to
Thank you!