Re: [Savannah-hackers-public] mercurial ssh access issues

[Sylvain Beucler]

Hi,

> >  In what cases did it happen, though? Initialy, in the disk image, user
> >  'admin' is member of 'siteadmin' (so he's entitled for a user account)
> >  and has no registered SSH key, so this should trigger the
> >  authorized_keys bug you reported, but AFAICS ~admin/.ssh/ did not
> >  contain a 'authorized_keys' file.
> 
> The problem was that the variable $authroized_keys was 0 (I guess
> because NULL was interpreted as 0, but I am not sure), which is
> different than '', so the check inside UserAddSSHKeys failed and a 0
> was added to authorized_keys file.

No, I mean, in what user context did this happen? How do you reproduce
the bug?

> If I am not wrong, checking for ($authorized_keys) instead of
> ($authorized_keys ne '') solves the problem with 0 and ''.

Yes, but it shouldn't be 0 in the first place; that's what I fixed.

> The problem is that hg-ssh uses the mercurial api, and I will not be
> able to do that in perl, so right now I don't really see how to solve
> this.

I hadn't noticed a first glance. What is 'dispatch' meant for?

Cheers,

-- 
Sylvain